For the most part, you're better off upgrading.
But, it can be useful to keep older buildings if you want to use those troops to fight in GvG. Also, occasionally an older unit retains its usefulness for a while: archers and anti-aircraft units come to mind.